Return 400 for dag_run_id with include_past/include_future in clearTaskInstances API#47036
Merged
Lee-W merged 1 commit intoapache:mainfrom Feb 25, 2025
Merged
Conversation
sunank200
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
sunank200
force-pushed
the
ti-clear-logical-date-none
branch
from
19f46a1 to
2cd1d73
Compare
1 task
sunank200
changed the title
Lee-W
approved these changes
Feb 25, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 28, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, combining a
dag_run_idwithinclude_pastorinclude_futureflags in theclearTaskInstancesAPI could lead to unintended behaviour - especially for manually triggered runs (logical_date=None), which cleared TIs from previous runs. This PR adds validation to return a 400 error when these flags are used together withdag_run_id.closes: #46887
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.